fix: make prepare wait for add to finish #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find! I played around with the prepare/create scripts but couldn't find what was aysnc and breaking the prepare script (not familiar enough with |
|
I confirm no more error using your fork & branch, for my previous repro #725 (comment) |
erisu
approved these changes
Nov 28, 2019
There was a problem hiding this comment.
Changes LGTM 👍
Also tested following cases
Environment
$ cordova -v
9.0.0 ([email protected])
Test Cases
Updated config.xml before platform add
$ cordova create iosTest2 com.foobar.iosTest2 iosTest2 && $_
Creating a new cordova project.
$ vi config.xml
--> ADDED <preference name="WKWebViewOnly" value="true" />
$ cordova platform add ../cordova-ios-5.2.0-dev.tgz
Using cordova-fetch for ../cordova-ios-5.2.0-dev.tgz
Warning: using prerelease platform [email protected].
Use 'cordova platform add ios@latest' to add the latest published version instead.
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.foobar.iosTest2
Name: iosTest2
iOS project created with [email protected]
Plugin 'cordova-plugin-whitelist' found in config.xml... Migrating it to package.json
Discovered saved plugin "cordova-plugin-whitelist". Adding it to the project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
$ cordova build ios --release --device
...
** ARCHIVE SUCCEEDED **
...
** EXPORT SUCCEEDED **
...
Updated config.xml after platform add before build
$ cordova create iosTest2 com.foobar.iosTest2 iosTest2 && $_
Creating a new cordova project.
$ cordova platform add ../cordova-ios-5.2.0-dev.tgz
Using cordova-fetch for ../cordova-ios-5.2.0-dev.tgz
Warning: using prerelease platform [email protected].
Use 'cordova platform add ios@latest' to add the latest published version instead.
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.foobar.iosTest2
Name: iosTest2
iOS project created with [email protected]
Plugin 'cordova-plugin-whitelist' found in config.xml... Migrating it to package.json
Discovered saved plugin "cordova-plugin-whitelist". Adding it to the project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
$ vi config.xml
--> ADDED <preference name="WKWebViewOnly" value="true" />
$ cordova build ios --release --device
...
** ARCHIVE SUCCEEDED **
...
** EXPORT SUCCEEDED **
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare is being run before add command finish because
fs.lstatis async and thecreateProjectis resolving beforefs.lstatfinishes.This PR changes
fs.lstattofs.lstatSyncto make the directory check sync and avoid to resolve before all create work is done.Closes #725